sage: remove optional jmol dep (and thus also jre8)#382929
Merged
collares merged 1 commit intoNixOS:masterfrom Mar 18, 2025
Merged
sage: remove optional jmol dep (and thus also jre8)#382929collares merged 1 commit intoNixOS:masterfrom
collares merged 1 commit intoNixOS:masterfrom
Conversation
We are now past Sage 10.5, and jmol is now optional so unneeded in the default env. See sagemath/sage#31027
amarshall
force-pushed
the
sage-improve
branch
from
92e7366 to
89de217
Compare
github-actions
bot
added
10.rebuild-darwin: 1-10
Member
|
I'd say this is a good change, but honestly I don't use 3D plots in Sage. Still, I think the best course of action is to merge this and wait to see if someone misses the functionality provided by Jmol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are now past Sage 10.5, and jmol is now optional so unneeded in the default env.
See sagemath/sage#31027
Things done
Tested basic CLI usage.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewx86_64-linux✅ 4 packages built:
Add a 👍 reaction to pull requests you find important.